Add section in depletion user's guide about comparing to other codes#3955
Open
paulromano wants to merge 3 commits into
Open
Add section in depletion user's guide about comparing to other codes#3955paulromano wants to merge 3 commits into
paulromano wants to merge 3 commits into
Conversation
shimwell
reviewed
Jun 4, 2026
| as possible: | ||
|
|
||
| - Geometry and material definitions | ||
| - Neutron cross section library (e.g., ENDF/B-VIII.0) |
Member
There was a problem hiding this comment.
is it worth mentioning the MCNP distributed endf conversion script on the data repo here
shimwell
approved these changes
Jun 4, 2026
Member
shimwell
left a comment
shimwell
left a comment
There was a problem hiding this comment.
looks good to me, helpful for users. I made an optional comment but this PR is also good to merge as it is
pshriwise
reviewed
Jun 4, 2026
| - Neutron cross section library (e.g., ENDF/B-VIII.0) | ||
| - Treatment of thermal scattering and unresolved resonance probability tables | ||
| - Neutron reactions accounted for in the depletion chain | ||
| - Decay data in the depletion chain |
Contributor
There was a problem hiding this comment.
We may want to call out isomeric branching ratios here specifically as well -- this was an entry that required manual adjustment in @OHTAESUK's work as well.
| For a meaningful comparison, align as many of the following inputs and methods | ||
| as possible: | ||
|
|
||
| - Geometry and material definitions |
Contributor
There was a problem hiding this comment.
Perhaps worth emphasizing that geometry and materials can both have temperature definitions, both implicitly via defaults or explicitly by setting them on cells/materials. Discrepancies would be expected from different temp assignments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a short subsection in the user's guide section on depletion about "Comparing to other codes", which should be very informative for those who are comparing OpenMC results to other codes. It also fixes a few miscellaneous Python issues that are causing warnings in my linter (e.g., using
!= Noneinstead ofis not None).Checklist
I have run clang-format (version 18) on any C++ source files (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)